#SwiftUI: Stop using AppStorage directly. It’s prone to typos, value mismatches and more.
Instead give yourself strongly typed keys and associated defaults, à la EnvironmentValues.
I’ve published my implementation as a package, but you can just as easily wrap AppStorage yourself with a few dozen lines.
@phill I’m doing almost the same by introducing a „TypedKey“, but added a buch of initializers to AppStorage. Upside: It’s as familiar as possible to anyone who knows AppStorage.
TypedKey is also used everywhere where having typed values and potentially default values makes sense. I strongly wonder why it’s not part of the system tbh.
@gernot @phill I am trying to understand if the benefits are mostly if you have default values because for optionals it seems that there isn’t much benefit. From the screenshot i didn’t see much improvements if you are already keeping your keys separate in an enum. I am genuinely curious if i am missing something here.
@keval @gernot beware that even if with an optional value the store will always return a default value. Double will return 0 if there is no entry, Bool will return false, etc. This can have subtle and unexpected consequences if you’re expecting nil.
By clearly defining your default values you’re making your codebase easier to reason with, test, etc.
@gernot @keval the AppStorage interface will always return its default value, however if you access the value through the store (e.g UserDefaults.standard.double(forKey:)) you will get the store's default instead.
Yet another reason for having a common interface everywhere!
https://developer.apple.com/documentation/foundation/userdefaults/1416581-double
@phill @keval Ah, I think now I see what you mean. Yeah, those early attempts at non-generic „typed“ UserDefaults should be deprecated in my opinion. All those late-90s APIs have a thick layer of abandoned concepts in them.